[PATCH] D65712: [Attributor] Introduce the IRAttribute helper struct

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

This series of commits broke the modular builds of LLVM.

See http://green.lab.llvm.org/green/view/Clang/job/clang-stage2-Rthinlto/242/
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/32798/consoleFull#-285067057a1ca8a51-895e-46c6-af87-ce24fa4cd561

I think the problem that the virtual method definitions in the modular headers pull in link-time dependencies for every client that imports the IPO module. The correct fix is likely to move all the virtual function bodies into the respective .cpp files. Can you please either revert the patch series or quickly fix this?

thanks!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65712/new/

https://reviews.llvm.org/D65712