[PATCH] D65756: [GlobalISel] Teach GlobalISelEmitter to treat used iPTRAny operands as pointer operands
Jessica Paquette via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 6 09:28:55 PDT 2019
paquette marked an inline comment as done.
paquette added inline comments.
================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:3523
+ if (IsIntrinsic)
+ OperandIsAPointer |= isParamAnyPtr(*II, i - 1);
+
----------------
arsenm wrote:
> Why isn't this part of isOperandAPointer?
Because to get at `II`, you need to use `Src`, which is a `TreePatternNode`. Since `isOperandAPointer` is a member function of `CodeGenInstruction`, it feels better to me personally to keep it concerned with things local to `CodeGenInstruction`.
Now that I'm looking at it again though, I think it could be moved to `CodeGenIntrinsic`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65756/new/
https://reviews.llvm.org/D65756
More information about the llvm-commits
mailing list