[PATCH] D65463: [WebAssembly] Fix conflict between ret legalization and sjlj

[Keno Fischer via Phabricator via llvm-commits]

loladiro marked 2 inline comments as done.
loladiro added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/lower-em-exceptions.ll:19
 ; CHECK-NEXT: store i32 0, i32* @__THREW__
-; CHECK-NEXT: call void @__invoke_void_i32(void (i32)* @foo, i32 3)
+; CHECK-NEXT: void @__invoke_void_i32(void (i32)* @foo, i32 3)
 ; CHECK-NEXT: %[[__THREW__VAL:.*]] = load i32, i32* @__THREW__
----------------
aheejin wrote:
> Nit: How about adding `call cc{{.*}}` here too show that invokes have been converted to calls, which is one of the main things this pass does? The same thing for similar lines in this file and lower-em-sjlj.ll too.
Ok, will do prior to commit.


================
Comment at: llvm/test/CodeGen/WebAssembly/lower-em-sjlj-sret.ll:13
+; Emscripten sjlj transformation
+define hidden {i32, i32} @legalized_to_sret() {
+entry:
----------------
aheejin wrote:
> Real nit: we can maybe remove `hidden`
sure


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65463/new/

https://reviews.llvm.org/D65463