[PATCH] D62007: [RISCV] Minimal stack realignment support

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 07:31:41 PDT 2019


asb added a comment.

In D62007#1614808 <https://reviews.llvm.org/D62007#1614808>, @lenary wrote:

> Address review feedback
>
> - implement targetHandlesStackFrameRounding to prevent stack being rounded twice.


Could you please implement this hook in a separate patch (either a parent or child of this one). The stack allocation and prolog/epilog code is a fiddly part of the backend, where there have been bugs in the past and I'm sure there will be bugs in the future. I'd much rather separate the changes to allow easily inspection, bisection etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62007/new/

https://reviews.llvm.org/D62007





More information about the llvm-commits mailing list