[PATCH] D65802: [DAGCombiner] Fold br(xor(xor(x, y), 1)) as br(x == y)

Roger Ferrer Ibanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 05:49:45 PDT 2019


rogfer01 created this revision.
Herald added subscribers: llvm-commits, s.egerton, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, MaskRay, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar, asb, aheejin, hiraditya, jgravelle-google, sbc100, javed.absar, dschuff.
Herald added a project: LLVM.
rogfer01 added a reviewer: efriedma.
rogfer01 set the repository for this revision to rG LLVM Github Monorepo.
Herald added a subscriber: jrtc27.
rogfer01 added a parent revision: D65801: [NFC] Add tests for boolean comparisons.

The existing code already considered this case. Unfortunately a typo in the condition prevents it from triggering. Also the existing code, had it run, forgot to do the folding.

This fixes PR42876


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D65802

Files:
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/test/CodeGen/AArch64/cmp-bool.ll
  llvm/test/CodeGen/ARM/cmp-bool.ll
  llvm/test/CodeGen/RISCV/cmp-bool.ll
  llvm/test/CodeGen/WebAssembly/reg-stackify.ll
  llvm/test/CodeGen/X86/cmp-bool.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65802.213590.patch
Type: text/x-patch
Size: 5551 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190806/91ce4b32/attachment.bin>


More information about the llvm-commits mailing list