[PATCH] D65786: [Attributor] Introduce a state wrapper class

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 added a comment.

LGTM with one question. Maybe this is an overkill, but do we even need to have isAssumed*AAType* as well as isKnown (eg. isAssumedNoFree())? I'm just thinking out loud.



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:938
   /// Return true if "willreturn" is assumed.
-  virtual bool isAssumedWillReturn() const = 0;
+  virtual bool isAssumedWillReturn() const { return getAssumed(); }
+
----------------
I think this virtual is not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65786/new/

https://reviews.llvm.org/D65786