[PATCH] D65787: [llvm-strip] Support --strip-sections with the llvm-strip command.

Tue Aug 6 05:41:17 PDT 2019

MaskRay added a comment.

In D65787#1616703 <https://reviews.llvm.org/D65787#1616703>, @jhenderson wrote:

> In D65787#1616681 <https://reviews.llvm.org/D65787#1616681>, @MaskRay wrote:
>
> > I am on the fence. On one side, for extensions that binutils does not support, I think it is fine to just support them in llvm-objcopy, not in llvm-strip. On the other side, `--strip-sections` is a strip-* option, so it isn't a bad fit for llvm-strip.
>
>
> We have a concrete use-case for this internally, so I'd like to have it if there isn't a good reason not to.

Then add this option.

The description should be changed to state that this is a strip option, so it seems a good fit for llvm-strip. We already have --strip-all --strip-all-gnu --strip-debug --strip-unneeded --strip-symbol so it seems natural to have another `--strip-*`.

> The reasons for this are unclear, so this patch adds the option to llvm-strip.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65787/new/

https://reviews.llvm.org/D65787