[PATCH] D65446: [yaml2obj/obj2yaml] - Add a basic support for extended section indexes.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/obj2yaml/elf-sht-symtab-shndx.yaml:21
+# CASE1-NEXT:     EntSize: 0x0000000000000004
+# CASE1-NEXT:     Content: '000000000100000002000000'
+# CASE1-NEXT: Symbols:
----------------
grimar wrote:
> jhenderson wrote:
> > I think it would be clearer for obj2yaml to emit an array of entries (and yaml2obj to consume them). What do you think? (We should allow explicit EntSize/Content in the YAML to allow creation of broken stuff too).
> > 
> > ```
> > - Name: .symtab_shndx
> >   Type: SHT_SYMTAB_SHNDX
> >   Link: .symtab
> >   Entries:
> >     - Value: 0
> >     - Value: 1
> >     - Value: 42
> > ```
> Sounds good. What about me doing this in a follow-up or do you prefer to have this from the start?
As obj2yaml should probably print the array version, that should be in first, otherwise you just have to update this test (but it's okay to then defer adding custom content to a later change if you want).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65446/new/

https://reviews.llvm.org/D65446