[PATCH] D65778: [FileCheck] Add missing includes in header

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/lib/Support/FileCheck.cpp:21
+#include "llvm/ADT/StringMap.h"
+#include "llvm/ADT/Optional.h"
+#include "llvm/Support/Error.h"
----------------
It's unsorted. Should probably be:

```
#include "llvm/ADT/Optional.h"
#include "llvm/ADT/StringMap.h"
#include "llvm/ADT/StringSet.h"
```

(In LLD we always sort headers, I am not sure this rule applies to whole LLVM, but I think it is).

But first of all I am unsure we want to include these headers after `"llvm/Support/FileCheck.h"` where
they are already included. Do we really want it? Why?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65778/new/

https://reviews.llvm.org/D65778