[llvm] r367793 - [Attributor][NFC] Create some attributes earlier

[David Blaikie via llvm-commits]

I'm seeing some internal asan failures attributed to this change - though
don't have a tidy/external reproduction yet (first pass/attempt to
reproduce this in an open source checkout did not produce asan failures in
the FunctionAttrs/liveness.ll test case that is failing internally).
Mentioning this in case it's relevant to you/if you're seeing something
similar, etc...

On Sun, Aug 4, 2019 at 11:39 AM Johannes Doerfert via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: jdoerfert
> Date: Sun Aug  4 11:40:01 2019
> New Revision: 367793
>
> URL: http://llvm.org/viewvc/llvm-project?rev=367793&view=rev
> Log:
> [Attributor][NFC] Create some attributes earlier
>
> Modified:
>     llvm/trunk/lib/Transforms/IPO/Attributor.cpp
>
> Modified: llvm/trunk/lib/Transforms/IPO/Attributor.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/Attributor.cpp?rev=367793&r1=367792&r2=367793&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Transforms/IPO/Attributor.cpp (original)
> +++ llvm/trunk/lib/Transforms/IPO/Attributor.cpp Sun Aug  4 11:40:01 2019
> @@ -2488,6 +2488,12 @@ void Attributor::identifyDefaultAbstract
>      Function &F, InformationCache &InfoCache,
>      DenseSet</* Attribute::AttrKind */ unsigned> *Whitelist) {
>
> +  // Check for dead BasicBlocks in every function.
> +  registerAA(*new AAIsDeadFunction(F, InfoCache));
> +
> +  // Every function might be "will-return".
> +  registerAA(*new AAWillReturnFunction(F, InfoCache));
> +
>    // Every function can be nounwind.
>    registerAA(*new AANoUnwindFunction(F, InfoCache));
>
> @@ -2542,12 +2548,6 @@ void Attributor::identifyDefaultAbstract
>      }
>    }
>
> -  // Every function might be "will-return".
> -  registerAA(*new AAWillReturnFunction(F, InfoCache));
> -
> -  // Check for dead BasicBlocks in every function.
> -  registerAA(*new AAIsDeadFunction(F, InfoCache));
> -
>    // Walk all instructions to find more attribute opportunities and also
>    // interesting instructions that might be queried by abstract attributes
>    // during their initialization or update.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190805/e26f560c/attachment.html>