[PATCH] D65609: Add gdb pretty printers for a wide variety of libc++ data structures.

[Sterling Augustine via Phabricator via llvm-commits]

saugustine added a comment.

In D65609#1613721 <https://reviews.llvm.org/D65609#1613721>, @EricWF wrote:

> wow. This is a fantastic amount of work. Thank you. No longer will libc++ accidentally break the pretty printers!


tamur and rdhindsa (cc'd as reviewers) both deserve strong credit for this. It wasn't solely me by a long shot. I will include them in the final commit message.

> I'm happy to handle the minutiae related to configuring the build and test suite. I check in some code to detect GDB and LLDB shortly.

Thank you--that will be very helpful.

I've updated the revision to address these comments.

In D65609#1611310 <https://reviews.llvm.org/D65609#1611310>, @Eugene.Zelenko wrote:

> Please also add installation, since pretty-printers should be shipped with libc++, same as GCC does with libstdc++ and its pretty-printers.


I wanted to discuss how to do that, but I think ericwf is thankfully taking that hassle from me.

In D65609#1615019 <https://reviews.llvm.org/D65609#1615019>, @ldionne wrote:

> In D65609#1613721 <https://reviews.llvm.org/D65609#1613721>, @EricWF wrote:
>
> > wow. This is a fantastic amount of work. Thank you. No longer will libc++ accidentally break the pretty printers!
>
>
> I want to echo this. This is really cool. I _really_ hope we can get something similar for LLDB.


I'm unfamiliar with how lldb handles scripting, but the python script portion of the framework is fairly short and straightforward.  The test program itself contains both its inputs and test cases, so lldb could be run against it no problem. Perhaps with an ifdef to use lldb-based comparison strings.



================
Comment at: libcxx/test/pretty_printers/gdb_pretty_printer_test.py:99
+gdb.events.exited.connect(exit_handler)
+#gdb.execute("b gdb_pretty_printer_test.sh.cpp:418")
+#gdb.execute("d 1")
----------------
ldionne wrote:
> I assume this is a remnant of prior testing?
Rats. Fixed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65609/new/

https://reviews.llvm.org/D65609