[PATCH] D65720: [WebAssembly] Regenerate SIMD Arithmetic tests

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

In D65720#1615544 <https://reviews.llvm.org/D65720#1615544>, @tlively wrote:

> I have mixed feelings about this. One one hand I understand that this file is huge and cross-cutting changes could cause a lot of manual updating work, but on the other hand each individual test was very readable and succinct. The auto-generated version would certainly be less work to maintain, but its enormous amount of irrelevant information and repetition is unfortunate. @aheejin, what do you think about this?


I have the same concerns. While I understand the convenience of using the auto generation script, the file is now far less readable and contains a lot more contents, and also all different test prefixes, some of which needed only for a few tests, are generated for every function. With the file being huge, it would also be hard to see if subsequent updates to the test are correct.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65720/new/

https://reviews.llvm.org/D65720