[PATCH] D65770: hwasan: Instrument globals.

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 14:15:49 PDT 2019


vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/hwasan/hwasan.cpp:221
+  s32 gv_relptr;
+  u32 info;
+};
----------------
Can this be just following?
  u32 size:24;
  u8 tag;


================
Comment at: compiler-rt/lib/hwasan/hwasan.cpp:236
 
-using namespace __hwasan;
+#define NT_LLVM_HWASAN_GLOBALS 3
+
----------------
could this be a normal constant?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65770/new/

https://reviews.llvm.org/D65770





More information about the llvm-commits mailing list