[PATCH] D65057: [ConstantFolding] Use FoldBitCast correctly

[Jameson Nash via Phabricator via llvm-commits]

vtjnash marked an inline comment as done.
vtjnash added inline comments.


================
Comment at: lib/Analysis/ConstantFolding.cpp:535-536
+        // For vector of pointer, we needed to first convert to a vector of integer, then do vector inttoptr
+        if (Res->isNullValue() && !LoadTy->isX86_MMXTy())
+          return Constant::getNullValue(LoadTy);
+        if (DL.isNonIntegralPointerType(LoadTy->getScalarType()))
----------------
lebedev.ri wrote:
> But didn't you just check that before?
We did, but on a different value.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65057/new/

https://reviews.llvm.org/D65057