[PATCH] D65768: hwasan: Untag global variable addresses in tests.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

In D65768#1615607 <https://reviews.llvm.org/D65768#1615607>, @hctim wrote:

> Understood. I'm not the biggest fan of putting macros all around the codebase - could we define our own `ErrorPrintf()/Printf()/strcmp()` and explicitly untag there? I think relying on explicit untagging everywhere may be error-prone, and it looks like we can reduce the mental overhead of remembering to explicitly untag.


If you forget to untag, your test will not pass once the global instrumentation change lands. So I'm personally not too concerned about this.

That said, adding the wrappers seems fine to me. I'll do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65768/new/

https://reviews.llvm.org/D65768