[PATCH] D65698: [GISel]: Add GISelKnownBits analysis

Mon Aug 5 13:02:00 PDT 2019

aditya_nandakumar marked 4 inline comments as done.
aditya_nandakumar added inline comments.

================
Comment at: llvm/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp:31-41
+  StringRef MIR = "  %3:_(s32) = G_TRUNC %0\n"
+                  "  %4:_(s32) = G_TRUNC %1\n"
+                  "  %5:_(s32) = G_CONSTANT i32 5\n"
+                  "  %6:_(s32) = G_CONSTANT i32 24\n"
+                  "  %7:_(s32) = G_CONSTANT i32 28\n"
+                  "  %8:_(s32) = G_SHL %3, %5\n"
+                  "  %9:_(s32) = G_SHL %4, %5\n"
----------------
paquette wrote:
> Can we have tests for the other opcodes you're adding support for in this patch?
Certainly - but I'm strapped for bandwidth right now to exhaustively add test cases for all of them. I ported this test from the IR version of KnownBits unit test.
Can we get this in now and then I can certainly add tests when I have a few cycles?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65698/new/

https://reviews.llvm.org/D65698