[PATCH] D65684: [WebAssembly] Lower ASan constructor priority on Emscripten
Guanzhong Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 5 13:01:55 PDT 2019
quantum added inline comments.
================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:132
static const uint64_t kAsanCtorAndDtorPriority = 1;
+static const uint64_t kAsanEmscriptenCtorAndDtorPriority = 50;
static const char *const kAsanReportErrorTemplate = "__asan_report_";
----------------
sbc100 wrote:
> Any reason not to change this for all platforms? In any case an explaining comment might be a good idea here.
I suspect doing that will break things on other platforms. I shall add a comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65684/new/
https://reviews.llvm.org/D65684
More information about the llvm-commits
mailing list