[PATCH] D65368: [DebugInfo] LiveDebugValues: Don't drop fragment information when restoring spills
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 5 12:54:10 PDT 2019
vsk added a reviewer: debug-info.
vsk added a comment.
Thanks. I think this looks reasonable, but don't have the bandwidth right now to test+merge a fix for llvm-9. + debug-info for more feedback/visibility.
================
Comment at: llvm/test/DebugInfo/MIR/X86/live-debug-values-restore.mir:31
+# CHECK-LABEL: name: g
+# CHECK-NOT: !DIExpression()
+
----------------
It's be great to move the checks closer to the MIR code they refer to. Also, as this patch includes a fix for fragment expressions, I think the check should validate the fragment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65368/new/
https://reviews.llvm.org/D65368
More information about the llvm-commits
mailing list