[PATCH] D65730: [Sanitizer] Linux Shadow mapping explicit thp support when in madvise mode

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cpp:91
+  else if (mode == 1)
+    return madvise((char *)addr, size, MADV_HUGEPAGE) == 0;
+  return true;
----------------
devnexen wrote:
> vitalybuka wrote:
> > Can we just remove transparent_hugepages/enabled check
> > and always do: "advise((char *)addr, size, MADV_HUGEPAGE) == 0;" ?
> > 
> > 
> In fact it makes sense only in madvise setting, in always it s supposed to always trying to do so ?
right, in "always" and "disabled" it's just no-op, but we can skip transparent_hugepages/enabled check


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65730/new/

https://reviews.llvm.org/D65730