[PATCH] D61289: [globalisel] Add G_SEXT_INREG

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/legalize-undef.mir:29
+    ; CHECK-DAG: [[DEF:%[0-9]+]]:_(s64) = G_IMPLICIT_DEF
+    ; CHECK-DAG: [[SHL:%[0-9]+]]:_(s64) = G_SHL [[DEF]], [[C]](s64)
+    ; CHECK-DAG: [[ASHR:%[0-9]+]]:_(s64) = G_ASHR [[SHL]], [[C]](s64)
----------------
dsanders wrote:
> aemerson wrote:
> > Did constant and impdef order change? If so we can just re-run the test update script.
> > Did constant and impdef order change?
> Yes.
> 
> Should instruction order matter for these tests? Legalization doesn't give any guarantees on the output order and using CHECK-DAG makes the test robust against that
It would, but as it's autogenerated It doesn't/shouldn't uses -DAG checks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61289/new/

https://reviews.llvm.org/D61289