[PATCH] D63782: [FPEnv] Add fptosi and fptoui constrained intrinsics

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:2931
+      DAG.ReplaceAllUsesOfValueWith(SDValue(Node,1), Tmp2);
+      // Replace the now UINT result.
+      ReplaceNodeWithValue(SDValue(Node, 0), Tmp1);
----------------
I think the comment has a typo or mistake in it.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:4829
+      Chain = Result.getValue(1);
+#if 0
+      // Relink the chain
----------------
Remove the commented out code.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:4867
+      Chain = SInt.getValue(1);
+#if 0
+      // Relink the chain
----------------
Remvoe the commented out code


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63782/new/

https://reviews.llvm.org/D63782