[PATCH] D65684: [WebAssembly] Lower ASan constructor priority on Emscripten

[Thomas Lively via Phabricator via llvm-commits]

tlively added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1780
 
+  const uint64_t CtorAndDtorPriority = GetCtorAndDtorPriority(TargetTriple);
+
----------------
You probably don't need a variable here since the value is only used once and the function name is plenty descriptive.


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2444
 
+  const uint64_t CtorAndDtorPriority = GetCtorAndDtorPriority(TargetTriple);
+
----------------
How about renaming this `Priority` or similar since there is a lot of repeated information otherwise?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65684/new/

https://reviews.llvm.org/D65684