[PATCH] D65609: Add gdb pretty printers for a wide variety of libc++ data structures.

Mon Aug 5 09:56:33 PDT 2019

Eugene.Zelenko added a comment.

In D65609#1615072 <https://reviews.llvm.org/D65609#1615072>, @ldionne wrote:

> In D65609#1615069 <https://reviews.llvm.org/D65609#1615069>, @Eugene.Zelenko wrote:
>
> > In D65609#1615019 <https://reviews.llvm.org/D65609#1615019>, @ldionne wrote:
> >
> > > In D65609#1613721 <https://reviews.llvm.org/D65609#1613721>, @EricWF wrote:
> > >
> > > > wow. This is a fantastic amount of work. Thank you. No longer will libc++ accidentally break the pretty printers!
> > >
> > >
> > > I want to echo this. This is really cool. I _really_ hope we can get something similar for LLDB.
> >
> >
> > LLDB has pretty-printers <https://github.com/llvm/llvm-project/tree/master/lldb/source/Plugins/Language/CPlusPlus>. They are implemented in C++ instead of scripting.
>
>
> Sorry, my point is that we don't have the pretty-printer tests checked into libc++ and part of its test suite, which has been a source of pain in the past. Changing that situation is what I was referring to when I said "I hope we can get something similar for LLDB".

Sorry for misunderstanding, but may be libc++ developers should run LLDB tests too? Or at least make sure that libc++ changes do  force LLDB tests on BuildBot and tests results should be monitored by committer?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65609/new/

https://reviews.llvm.org/D65609