[PATCH] D65750: [LNT] Add missing method docstrings in lnt.testing

Danila Malyutin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 09:21:44 PDT 2019


danilaml accepted this revision.
danilaml added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lnt/testing/__init__.py:47
     def check(self):
+        """Check object members are adequate to generate an LNT json report
+        file when rendering that instance.
----------------
Check that ...?


================
Comment at: lnt/testing/__init__.py:66
+        """Return a LNT json report file format as a string, where each
+        object is indented by indent spaces compared to his parent.
+        """
----------------
its parent?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65750/new/

https://reviews.llvm.org/D65750





More information about the llvm-commits mailing list