[PATCH] D65644: [AMDGPU] gfx10 atomic optimizer changes.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:289
+        B, Op, V,
+        B.CreateIntrinsic(Intrinsic::amdgcn_update_dpp, Ty,
+                          {Identity, V, B.getInt32(DPP::ROW_SHR0 | 1 << Idx),
----------------
I think it would end up being shorter/less line wrapping if you separately got the declaration for the update_dpp intrinsic and reused it in all of these places


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:293
+  }
+  if (ST->getGeneration() < AMDGPUSubtarget::GFX10) {
+    // GFX9 has DPP row broadcast operations.
----------------
I'm trying to avoid explicit getGeneration checks everywhere, and restricting them to all be in the Subtarget. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65644/new/

https://reviews.llvm.org/D65644