[PATCH] D65745: [llvm-ar][test] Correct tests marked as expected fails

Owen Reynolds via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 06:58:47 PDT 2019


gbreynoo created this revision.
gbreynoo added reviewers: MaskRay, rupprecht, JamesNagurne.
Herald added subscribers: llvm-commits, kristof.beyls, javed.absar.
Herald added a project: LLVM.

In diff `D64802` I marked three tests as expected failures for darwin but James Nagurne saw these fail on his downstream embedded ARM cross compiler. 
I believe `XFAIL: system-darwin` should be used instead of  using `XFAIL: darwin` due to the problem being related to the darwin host and not the target.


Repository:
  rL LLVM

https://reviews.llvm.org/D65745

Files:
  llvm/test/tools/llvm-ar/extract.test
  llvm/test/tools/llvm-ar/mri-utf8.test
  llvm/test/tools/llvm-ar/print.test


Index: llvm/test/tools/llvm-ar/print.test
===================================================================
--- llvm/test/tools/llvm-ar/print.test
+++ llvm/test/tools/llvm-ar/print.test
@@ -1,5 +1,5 @@
 ## Test Print output
-# XFAIL: darwin
+# XFAIL: system-darwin
 
 RUN: rm -rf %t && mkdir -p %t
 RUN: echo file1 > %t/1.txt
Index: llvm/test/tools/llvm-ar/mri-utf8.test
===================================================================
--- llvm/test/tools/llvm-ar/mri-utf8.test
+++ llvm/test/tools/llvm-ar/mri-utf8.test
@@ -1,5 +1,5 @@
 # Test non-ascii archive members
-# XFAIL: darwin
+# XFAIL: system-darwin
 
 RUN: rm -rf %t && mkdir -p %t/extracted
 
Index: llvm/test/tools/llvm-ar/extract.test
===================================================================
--- llvm/test/tools/llvm-ar/extract.test
+++ llvm/test/tools/llvm-ar/extract.test
@@ -1,5 +1,5 @@
 ## Test extract operation.
-# XFAIL: darwin
+# XFAIL: system-darwin
 
 RUN: rm -rf %t && mkdir -p %t/extracted/
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65745.213348.patch
Type: text/x-patch
Size: 986 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190805/0a288f98/attachment.bin>


More information about the llvm-commits mailing list