[PATCH] D65649: [RISCV] Add MC encodings and tests of the Bit Manipulation extension

[Simon Cook via Phabricator via llvm-commits]

simoncook added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCV.td:48
+    : SubtargetFeature<"bb", "HasStdExtZbb", "true",
+                       "'Zbb' (Base bit Manipulation Instructions)">;
+def HasStdExtZbb : Predicate<"Subtarget->hasStdExtZbb()">,
----------------
nitpick: the capitalisation here looks weird.


================
Comment at: llvm/lib/Target/RISCV/RISCV.td:94
+
+def HasStdExtZbbOrZbp
+    : Predicate<"Subtarget->hasStdExtZbb() || Subtarget->hasStdExtZbp()">;
----------------
This predicate probably needs a comment


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoB.td:17
+
+class RVBInstShift<bits<5> funct5, bits<3> funct3, RISCVOpcode opcode,
+                   string opcodestr>
----------------
Probably worth a comment noting that the intent is to move these to the `InstrFormats` file once `B` has been ratified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65649/new/

https://reviews.llvm.org/D65649