[PATCH] D65734: [llvm-objdump] Quote filename to fix windows test failure
Douglas Yung via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 5 02:10:16 PDT 2019
dyung added a comment.
I'm not at a Windows machine at the moment, so I can't test your fix, but I'm doubtful that it would actually work.
I think that in my experience trying to get "[[FILE]]" to work on Windows and non-Windows platforms is really hard. You might want to try another approach. Do you need to explicitly verify the entire path is present? Or would it be enough to just verify that the test filename appears in that line?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65734/new/
https://reviews.llvm.org/D65734
More information about the llvm-commits
mailing list