[PATCH] D65653: [AArch64] Change location of frame-record within callee-save area.

Mon Aug 5 01:03:43 PDT 2019

kristof.beyls added inline comments.

================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:88
 //
 // FIXME: also explain the redzone concept.
 // FIXME: also explain the concept of reserved call frames.
----------------
I wonder if it would be a good idea to record the rationale for (some of the) order in which specific blocks are put in the frame record?
I think it would be useful to extend this comment, stating that the frame record is placed specifically to be able to make use of VL-scaled addressing modes to directly access SVE objects from the frame-pointer.
I feel the frame layout code is pretty complex, and therefore it helps to spell out the higher-level design rationales at the beginning of this file in a comment.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65653/new/

https://reviews.llvm.org/D65653