[PATCH] D47927: [WIP][TargetLowering] Simplify expansion of S{ADD,SUB}O

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

The changes for vector arithmetic look nice.



================
Comment at: llvm/test/CodeGen/RISCV/arith-with-overflow.ll:34
+; RV32I-NEXT:    slt a0, a3, a0
+; RV32I-NEXT:    xor a0, a1, a0
 ; RV32I-NEXT:    ret
----------------
It's probably worth adding a testcase where the i1 result is used as the operand to a branch, to show we correctly fold the xor into the branch.  (See also https://bugs.llvm.org/show_bug.cgi?id=42876 .)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47927/new/

https://reviews.llvm.org/D47927