[PATCH] D65726: [gold] Fix X86/strip_names.ll after r367755

[Nathan Chancellor via Phabricator via llvm-commits]

nathanchance created this revision.
nathanchance added reviewers: tejohnson, t.p.northover.
Herald added a project: LLVM.
nathanchance edited the summary of this revision.

Running ninja check-llvm fails like so:

  [401/402] Running the LLVM regression tests
  FAIL: LLVM :: tools/gold/X86/strip_names.ll (31009 of 32927)
  ...
  Exit Code: 1
  
  Command Output (stderr):
  --
  /home/nathan/cbl/tc-build/llvm-project/llvm/test/tools/gold/X86/strip_names.ll:23:11:
  error: NONAME: expected string not found in input
  ; NONAME: @foo(i32)
            ^
  <stdin>:6:18: note: scanning from here
  @GlobalValueName = global i32 0
                   ^
  <stdin>:8:12: note: possible intended match here
  define i32 @foo(i32 %0) {
             ^
  
  --

This appears to be missed by r367755 (git commit a009a60a917bc30940422bcef73f8270566d78db <https://reviews.llvm.org/rGa009a60a917bc30940422bcef73f8270566d78db>),
as running the script on it does not produce this diff and I do not know
enough about Python to fix it.

After this, the regression tests pass as expected.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D65726

Files:
  llvm/test/tools/gold/X86/strip_names.ll


Index: llvm/test/tools/gold/X86/strip_names.ll
===================================================================
--- llvm/test/tools/gold/X86/strip_names.ll
+++ llvm/test/tools/gold/X86/strip_names.ll
@@ -20,7 +20,7 @@
 ; CHECK:  ret i32 %add
 
 ; NONAME: @GlobalValueName
-; NONAME: @foo(i32)
+; NONAME: @foo(i32 %0)
 ; NONAME-NOT: somelabel:
 ; NONAME:  %2 = load i32, i32* @GlobalValueName
 ; NONAME:  %3 = add i32 %0, %2


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65726.213264.patch
Type: text/x-patch
Size: 427 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190804/87391e96/attachment.bin>