[PATCH] D63628: AMD K10 (Barcelona) Initial Scheduler model
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Aug 4 06:46:55 PDT 2019
RKSimon added inline comments.
================
Comment at: include/llvm/TableGen/Record.h:1271
+ << " with non-record type!\n";
+ assert(false && "FieldInit");
+ }
----------------
lebedev.ri wrote:
> courbet wrote:
> > `llvm_unreachable` ?
> I'll split this int a separate patch
Split this off? Also, the llvm_unreachable message needs improvement to be useful.
================
Comment at: lib/Target/X86/X86.td:805
+ FeatureFastScalarShiftMasks];
+ list<SubtargetFeature> BarcelonaFeatures = BarcelonaInheritableFeatures;
----------------
Can this feature list refactor be split off as well?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63628/new/
https://reviews.llvm.org/D63628
More information about the llvm-commits
mailing list