[PATCH] D64700: [SLPVectorizer] [NFC] Avoid repetitive calls to getSameOpcode().
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Aug 4 06:31:05 PDT 2019
RKSimon added a subscriber: Vasilis.
RKSimon added a comment.
one minor - @Vasilis @ABataev any comments?
================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:1270
+ return (MainOp->getOpcode() == CheckedOpcode ||
+ AltOp->getOpcode() == CheckedOpcode);
+ }
----------------
Can this ever get called when MainOp or AltOp is null? You test for that case below in getOpcode/getAltOpcode
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64700/new/
https://reviews.llvm.org/D64700
More information about the llvm-commits
mailing list