[PATCH] D65710: [Attributor] Use proper ID for attribute lookup

[Hideto Ueno via Phabricator via llvm-commits]

uenoku accepted this revision.
uenoku added a comment.
This revision is now accepted and ready to land.

To use the address as their id seems very reasonable.
I think we need to modify some comments which refer to `AAType::ID`.

Otherwise, LGTM.



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:226
   ///  (2) their argument number (\p ArgNo, or Argument::getArgNo()), and
   ///  (3) their default attribute kind (see AAType::ID).
   template <typename AAType> AAType &registerAA(AAType &AA, int ArgNo = -1) {
----------------
"default attribute kind" to "attribute id" or something like that.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:281
   /// an argument positions (or -1) on the outer level, and attribute kinds
   /// (Attribute::AttrKind) on the inner level.
   ///{
----------------
"attribute kinds(Attribute::AttrKind) " to "attribute id(AAType::ID)" or something like that.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65710/new/

https://reviews.llvm.org/D65710