[PATCH] D65680: [yaml2obj][tests] Fix overly restrictive od output check

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast marked 2 inline comments as done.
hubert.reinterpretcast added a comment.

In D65680#1613484 <https://reviews.llvm.org/D65680#1613484>, @MaskRay wrote:

> Can you just dump the output of `od -t x1 -v -j 0x3a -N 1 %t3` on AIX? That would be more descriptive I think. It also helps us decide how to test.


Here it is from AIX:

  0000000  01
  0000001

Here is the corresponding output from another platform (where the old check pattern worked):

  0000000072    01
  0000000073

In theory, it could also be this:

  000000003A    01
  000000003B



================
Comment at: test/tools/yaml2obj/elf-header-sh-fields.yaml:50
+# NEWSIZE: {{^[^[:blank:]]+}} 01
+# OLDSIZE: {{^[^[:blank:]]+}} 40
 
----------------
grimar wrote:
> Previously it tested that `e_shentsize` in ELF header at offset 0x72 contained value 64 (0x40) and with this YAML we changed it to 0x01.
> But your version just test that somewhere in the file there are bytes 0x01 and 0x40 I think. Am I missing something?
> But your version just test that somewhere in the file there are bytes 0x01 and 0x40 I think.
My version tests that there is a byte whose value is 0x01 or 0x40 (for `NEWSIZE` and `OLDSIZE`, respectively) at offset 0x3a (octal 072).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65680/new/

https://reviews.llvm.org/D65680