[PATCH] D65671: [yaml2obj][tests] Replace 8-byte `od` conversion with 1-byte conversion

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 3 08:05:55 PDT 2019


MaskRay added a comment.

In D65671#1613491 <https://reviews.llvm.org/D65671#1613491>, @hubert.reinterpretcast wrote:

> In D65671#1613487 <https://reviews.llvm.org/D65671#1613487>, @MaskRay wrote:
>
> > Is there a plan that AIX od will implement `x8`?
>
>
> I've requested the change, but I cannot make any promises on delivery vehicle.
>
> > This case is probably benign but I'm concerned the limitation will make testing harder on most other platforms.
>
> I am not sure that it is in the best interest of anyone to use other than `x1` unless if they want byte-order-aware conversion for a binary file encoded in the native byte order of the host.


I think you meant `od` is not binary byte-order aware. It makes sense


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65671/new/

https://reviews.llvm.org/D65671





More information about the llvm-commits mailing list