[PATCH] D65685: Eliminate implicit Register->unsigned conversions in VirtRegMap. NFC

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 2 20:33:07 PDT 2019


dsanders marked an inline comment as done.
dsanders added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/Register.h:109
 
+  unsigned get() const { return Reg; }
+
----------------
arsenm wrote:
> I would somewhat prefer to call this value() or getValue()
Hmm, `SrcReg.value()` would give the wrong impression. `SrcReg.id()`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65685/new/

https://reviews.llvm.org/D65685





More information about the llvm-commits mailing list