[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc on ARM
Jian Cai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 2 18:13:54 PDT 2019
jcai19 added a comment.
In D65019#1594704 <https://reviews.llvm.org/D65019#1594704>, @jcai19 wrote:
> In D65019#1594289 <https://reviews.llvm.org/D65019#1594289>, @efriedma wrote:
>
> > I don't like introducing magic calling convention rules for a non-intrinsic function with a specific name; we should model this more explicitly somehow. Probably the simplest thing to do would be to introduce an ARM intrinsic, lower it to a pseudo-instruction, and expand it late (in ExpandPostRAPseudos or something like that).
>
So I have implemented the codegen part as suggested. To add a new intrinsic for this call seems would introduce quite some code to the target-independent part of SelectionDAG, specifically SelectionDAGBuilder and SelectionDAG classes, just for ARM. Is that wanted? Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65019/new/
https://reviews.llvm.org/D65019
More information about the llvm-commits
mailing list