[PATCH] D64845: [GlobalISel] Check LLT size matches memory size for non-truncating stores.
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 2 16:19:17 PDT 2019
aemerson marked an inline comment as done.
aemerson added a comment.
In D64845#1613091 <https://reviews.llvm.org/D64845#1613091>, @dsanders wrote:
> That change LGTM. Do you have a test case for your target?
Thanks, it's only exposed with another patch though so I can't add that test here.
================
Comment at: llvm/test/TableGen/address-space-patfrags.td:123
// Test truncstore with specific MemoryVT
// GISEL: GIM_Try, /*On fail goto*//*Label 3*/ {{[0-9]+}}, // Rule ID 3 //
----------------
Just seen this incorrect comment, will fix in the commit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64845/new/
https://reviews.llvm.org/D64845
More information about the llvm-commits
mailing list