[PATCH] D65253: [sanitizer_common] Replace forkpty with posix_spawn on Darwin

[Julian Lettner via Phabricator via llvm-commits]

yln marked an inline comment as done.
yln added a comment.

In D65253#1607640 <https://reviews.llvm.org/D65253#1607640>, @kubamracek wrote:

> Thanks! This looks like a great step in the right direction. An overall question first: Should we use posix_spawn for *all platforms*? IIRC, unifying the launch paths was discussed on mailing lists before and sounds desirable.


I agree that this should be the end goal. For this patch, I would prefer to keep it Darwin-only to reduce the scope, especially since multiple people already attempted this before.
Also, I wouldn't be able to debug this locally for other platforms. How about doing this as a first step (of course I want to avoid doing anything that would prevent adopting this on other platforms) and going from there?



================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_mac.cc:53
   explicit AtosSymbolizerProcess(const char *path, pid_t parent_pid)
-      : SymbolizerProcess(path, /*use_forkpty*/ true) {
+      : SymbolizerProcess(path, /*use_posix_spawn*/ true) {
     // Put the string command line argument in the object so that it outlives
----------------
vitalybuka wrote:
> Do we have use_posix_spawn = false on mac anywhere?
We have `LLVMSymbolizerProcess` which doesn't specify it and therefore gets the default `false`. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65253/new/

https://reviews.llvm.org/D65253