[PATCH] D65671: [yaml2obj][tests] Replace 8-byte `od` conversion with 1-byte conversion

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 2 11:41:19 PDT 2019


hubert.reinterpretcast created this revision.
hubert.reinterpretcast added reviewers: grimar, daltenty, xingxue, jasonliu.
Herald added a project: LLVM.

`od` on AIX does not seem to implement 8-byte integer conversions. Work around this by using 1-byte conversions, which can be used in this case since the value is byte-order insensitive.


Repository:
  rL LLVM

https://reviews.llvm.org/D65671

Files:
  test/tools/yaml2obj/elf-override-shoffset.yaml
  test/tools/yaml2obj/elf-override-shsize.yaml


Index: test/tools/yaml2obj/elf-override-shsize.yaml
===================================================================
--- test/tools/yaml2obj/elf-override-shsize.yaml
+++ test/tools/yaml2obj/elf-override-shsize.yaml
@@ -72,13 +72,13 @@
 
 # RUN: yaml2obj --docnum=2 %s -o %t2
 # RUN: yaml2obj --docnum=3 %s -o %t3
-# RUN: od -t x8 -v %t2 > %t.txt
-# RUN: od -t x8 -v %t3 >> %t.txt
+# RUN: od -t x1 -v %t2 > %t.txt
+# RUN: od -t x1 -v %t3 >> %t.txt
 # RUN: FileCheck %s --input-file=%t.txt --check-prefix=CASE2
 
-# CASE2: [[OFFSET:.*]] fefefefefefefefe
+# CASE2: [[OFFSET:.*]] fe fe fe fe fe fe fe fe
 # CASE2: [[FILESIZE:.*]]{{$}}
-# CASE2: [[OFFSET]] fefefefefefefefe
+# CASE2: [[OFFSET]] fe fe fe fe fe fe fe fe
 # CASE2: [[FILESIZE]]{{$}}
 
 --- !ELF
Index: test/tools/yaml2obj/elf-override-shoffset.yaml
===================================================================
--- test/tools/yaml2obj/elf-override-shoffset.yaml
+++ test/tools/yaml2obj/elf-override-shoffset.yaml
@@ -73,13 +73,13 @@
 
 # RUN: yaml2obj --docnum=2 %s -o %t2
 # RUN: yaml2obj --docnum=3 %s -o %t3
-# RUN: od -t x8 -v %t2 > %t.txt
-# RUN: od -t x8 -v %t3 >> %t.txt
+# RUN: od -t x1 -v %t2 > %t.txt
+# RUN: od -t x1 -v %t3 >> %t.txt
 # RUN: FileCheck %s --input-file=%t.txt --check-prefix=CASE2
 
-# CASE2: [[OFFSET:.*]] fefefefefefefefe
+# CASE2: [[OFFSET:.*]] fe fe fe fe fe fe fe fe
 # CASE2: [[FILESIZE:.*]]{{$}}
-# CASE2: [[OFFSET]] fefefefefefefefe
+# CASE2: [[OFFSET]] fe fe fe fe fe fe fe fe
 # CASE2: [[FILESIZE]]{{$}}
 
 --- !ELF


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65671.213101.patch
Type: text/x-patch
Size: 1520 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190802/b4e27821/attachment.bin>


More information about the llvm-commits mailing list