[PATCH] D65624: [lit] Print internal env commands

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Suggestion, but this looks good too.



================
Comment at: llvm/utils/lit/lit/TestRunner.py:881
             cmd_shenv = ShellEnvironment(shenv.cwd, shenv.env)
             updateEnv(cmd_shenv, j)
 
----------------
I think it would be clearer to make updateEnv return the new command to run after env instead of modifying cmd.args. We copy cmd.args on line 903 currently anyway.


================
Comment at: llvm/utils/lit/lit/TestRunner.py:915
             if not executable:
                 raise InternalShellError(j, '%r: command not found' % j.args[0])
 
----------------
If you take my suggestion, this needs to use `args` not `j.args`, since it will refer to "env" and not the real exe for env-prefixed commands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65624/new/

https://reviews.llvm.org/D65624