[PATCH] D65273: [llvm-objcopy] - Reimplement strip-dwo-groups.test to stop using the precompiled object.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D65273#1612246 <https://reviews.llvm.org/D65273#1612246>, @gchatelet wrote:

> The test appears to fail when the compilation path contains the `debug_` substring.
>  This is not ideal.
>
>   FAIL: LLVM :: tools/llvm-objcopy/ELF/strip-dwo-groups.test (1254 of 2021)
>   ******************** TEST 'LLVM :: tools/llvm-objcopy/ELF/strip-dwo-groups.test' FAILED ********************
>   Script:
>   --
>   : 'RUN: at line 1';   /tmp/llvm-project_debug_compiled-with-clang/bin/yaml2obj /redacted/llvm-project/llvm/test/tools/llvm-objcopy/ELF/strip-dwo-groups.test -o /tmp/llvm-project_debug_compiled-with-clang/test/tools/llvm-objcopy/ELF/Output/strip-dwo-groups.test.tmp
>   : 'RUN: at line 2';   /tmp/llvm-project_debug_compiled-with-clang/bin/llvm-objcopy --strip-dwo /tmp/llvm-project_debug_compiled-with-clang/test/tools/llvm-objcopy/ELF/Output/strip-dwo-groups.test.tmp
>   : 'RUN: at line 3';   /tmp/llvm-project_debug_compiled-with-clang/bin/llvm-readobj --symbols -S --elf-section-groups /tmp/llvm-project_debug_compiled-with-clang/test/tools/llvm-objcopy/ELF/Output/strip-dwo-groups.test.tmp | /tmp/llvm-project_debug_compiled-with-clang/bin/FileCheck /redacted/llvm-project/llvm/test/tools/llvm-objcopy/ELF/strip-dwo-groups.test --implicit-check-not=debug_
>   --
>   Exit Code: 1
>  
>   Command Output (stderr):
>   --
>   command line:1:22: error: CHECK-NOT: excluded string found in input
>   -implicit-check-not='debug_'
>                        ^
>   <stdin>:2:25: note: found here
>   File: /tmp/llvm-project_debug_compiled-with-clang/test/tools/llvm-objcopy/ELF/Output/strip-dwo-groups.test.tmp
>                           ^~~~~~
>  
>   --
>  
>   ********************
>   Testing Time: 6.87s
>   ********************
>   Failing Tests (1):
>       LLVM :: tools/llvm-objcopy/ELF/strip-dwo-groups.test
>  
>


Thanks for reporting! I committed rL367702 <https://reviews.llvm.org/rL367702>, it should fix this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65273/new/

https://reviews.llvm.org/D65273