[PATCH] D65610: Robustify update_test_checks.py to non-autogened tests, and add a mode to skip non-autogenerated ones

[Philip Reames via Phabricator via llvm-commits]

reames marked 3 inline comments as done.
reames added a comment.

In D65610#1611868 <https://reviews.llvm.org/D65610#1611868>, @RKSimon wrote:

> Could this functionality be added to all the update*py scripts?


Could be reasonable done, but given the divergence already existing, would need to be hand implemented for each.  I'm not volunteering.



================
Comment at: utils/update_test_checks.py:113
+      if "|" not in l:
+        print('WARNING: Skipping unparseable RUN line: %s' % (l), file=sys.stderr)
+        continue
----------------
MaskRay wrote:
> `'...........{}'.format(l)` is usually preferred over `print('WARNING: Skipping unparseable RUN line: %s' % (l,), file=sys.stderr)` (note comma after `l`l)
> 
> The comma makes it a one-element tuple. `(l)` is the same as `l`.
I'd prefer to follow the style of all the surrounding code which uses this construct.  

p.s. The common vs non-common form appear to evaluate exactly the same.  (Based on the output of a test only)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65610/new/

https://reviews.llvm.org/D65610