[PATCH] D65651: [ELF] Move R_*_IRELATIVE from .rel[a].plt to .rel[a].dyn unless --pack-dyn-relocs=android[+relr]

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

In D65651#1612547 <https://reviews.llvm.org/D65651#1612547>, @MaskRay wrote:

> > Have you checked whether we can reasonably expect this to be universal or does this need to be done on a per-architecture basis?
>
> On non-Android, it is universal to place R_*_IRELATIVE in .rel[a].dyn :)


Are you saying that that's the behaviour of an existing linker? If so, this change is fine with me. Otherwise we need to be careful because if there is a dynamic loader out there that only supports `R_*_IRELATIVE` in `.rel[a].plt` and not in `.rel[a].dyn` on some architecture (basically the inverse of the situation that you discovered), your change would break that dynamic loader on that architecture.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65651/new/

https://reviews.llvm.org/D65651