[PATCH] D65661: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D65661#1612558 <https://reviews.llvm.org/D65661#1612558>, @Dor1s wrote:

> In D65661#1612546 <https://reviews.llvm.org/D65661#1612546>, @lebedev.ri wrote:
>
> > In D65661#1612541 <https://reviews.llvm.org/D65661#1612541>, @Dor1s wrote:
> >
> > > If this change gets accepted, any clang user should be able to use it via `#include <fuzzer/FuzzedDataProvider.h>`, rather than have it somewhere in their repo. It is not tied to `-fsanitizer=fuzzer` or any other compiler flags.
> >
> >
> > I think that misses the point, it's still a compiler lock-in - does that work with gcc?
>
>
> I don't think gcc is a good choice for fuzzing :)


...
Yep, i failed to convey the problem.
Any code that uses that header will get locked into compiler that provides said header,
unless they resort to bundling said header in the first place, which will be frowned upon.
Any code - at least the fuzzers, which somewhat contradicts the recommendations of oss-fuzz
for fuzz targets to be tested during *normal* builds. And really, this structure would need to
be consistently used through the code for best results,
in which case the entire codebase will get compiler-locked.

But i guess these concerns are completely insane/alien to everyone in nowadays monoculture world.

> That is also covered in the CL summary.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65661/new/

https://reviews.llvm.org/D65661