[PATCH] D65651: [ELF] Move R_*_IRELATIVE from .rel[a].plt to .rel[a].dyn unless --pack-dyn-relocs=android[+relr]

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

With this dynamic loaders will now need to be able to understand IRELATIVE relocations in `.rela.dyn`. Have you checked whether we can reasonably expect this to be universal or does this need to be done on a per-architecture basis?



================
Comment at: ELF/Writer.cpp:507
 
   // The relaIplt immediately follows .rel.plt (.rel.dyn for ARM) to ensure
   // that the IRelative relocations are processed last by the dynamic loader.
----------------
Update comment


================
Comment at: ELF/Writer.cpp:1071
 
   // .rela_iplt_{start,end} mark the start and the end of .rela.plt section.
   if (ElfSym::relaIpltStart && in.relaIplt->isNeeded()) {
----------------
Update comment


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65651/new/

https://reviews.llvm.org/D65651