[PATCH] D47770: [MVT][SVE] Add EVT strings and Type mapping

[David Greene via Phabricator via llvm-commits]

greened added a comment.

LGTM, thanks!



================
Comment at: llvm/lib/CodeGen/ValueTypes.cpp:208
   case MVT::v8f64:   return "v8f64";
+  case MVT::nxv1i1:  return "nxv1i1";
+  case MVT::nxv2i1:  return "nxv2i1";
----------------
This isn't a comment on this patch per se but rather a question about this code overall.  Why do we have all these vector and integer cases, for SVE and non-SVE?  It seems like the default case should handle them all.

I'm not at all saying you should change this.  It's just an observation for a possible future NFC change from <someone>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47770/new/

https://reviews.llvm.org/D47770