[PATCH] D59978: [Attributor] Deduce the "no-return" attribute for functions

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 2 08:40:44 PDT 2019


Meinersbur added inline comments.


================
Comment at: llvm/test/Transforms/FunctionAttrs/fn_noreturn.ll:85
 ;
-; FIXME: no-return missing
+; FIXME: no-return missing (D65243 should fix this)
 ; CHECK: Function Attrs: nofree noinline norecurse nosync nounwind readnone uwtable
----------------
I think this loop should not be `noreturn`. The loop deletion pass will remove this loop (due to not having side-effects), simplifying it to
```
entry:
  ret i32 %a
```
which obviously returns.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59978/new/

https://reviews.llvm.org/D59978





More information about the llvm-commits mailing list