[PATCH] D63547: [AIX]Global Address Lowering

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3169
+                      (PPCtoc_entry tglobaladdr:$disp, i32:$reg))]>;
+def ADDIStocHA: PPCEmitTimePseudo<(outs gprc:$rD), (ins gprc_nor0:$reg, tocentry32:$disp),
+                        "#ADDIStocHA",
----------------
To be consistent with the above lines, add a space before the `:`.


================
Comment at: llvm/lib/Target/PowerPC/PPCTOCRegDeps.cpp:115
+          MBB.getParent()->getSubtarget<PPCSubtarget>().isPPC64();
+      const unsigned TOCReg = (isPPC64) ? PPC::X2 : PPC::R2;
+
----------------
Remove the extra parentheses.


================
Comment at: llvm/lib/Target/PowerPC/PPCTargetMachine.cpp:258
+  
+  assert(TT.isOSBinFormatELF() && "All remaining PPC OSs are ELF based.");
+  
----------------
"OSes" is the spelling used in various messages.


================
Comment at: llvm/lib/Target/PowerPC/PPCTargetMachine.cpp:263
+
+  assert(TT.isArch64Bit() && "Unsupported  PPC architecture.");
+  return CodeModel::Medium;
----------------
Fix the two consecutive spaces.


================
Comment at: llvm/test/CodeGen/PowerPC/lower-globaladdr32-aix.ll:2
+; RUN: llc -mtriple powerpc-ibm-aix-xcoff -code-model=small \
+; RUN: -stop-after=machine-cp -print-before=simple-register-coalescing 2>&1 < \
+; RUN: %s | FileCheck --check-prefix=SMALL %s
----------------
`lit` can display stderr separately from stdout. If we are not checking for error messages, then redirecting stderr to stdout does not seem advantageous.


================
Comment at: llvm/test/CodeGen/PowerPC/lower-globaladdr32-aix.ll:9
+; RUN: llc -mtriple powerpc-ibm-aix-xcoff -code-model=large \
+; RUN: -stop-after=machine-cp -print-before=simple-register-coalescing 2>&1 < \
+; RUN: %s | FileCheck --check-prefix=LARGE %s
----------------
Same comment.


================
Comment at: llvm/test/CodeGen/PowerPC/lower-globaladdr32-aix.ll:13
+; RUN: llc -mtriple powerpc-ibm-aix-xcoff -stop-after=machine-cp \
+; RUN: -print-before=simple-register-coalescing 2>&1 < %s | FileCheck \
+; RUN: --check-prefix=SMALL %s
----------------
Same comment.


================
Comment at: llvm/test/CodeGen/PowerPC/lower-globaladdr64-aix.ll:2
+; RUN: llc -mtriple powerpc64-ibm-aix-xcoff -code-model=small \
+; RUN: -stop-after=machine-cp -print-before=simple-register-coalescing 2>&1 < \
+; RUN: %s | FileCheck --check-prefix=SMALL %s
----------------
Same comment.


================
Comment at: llvm/test/CodeGen/PowerPC/lower-globaladdr64-aix.ll:9
+; RUN: llc -mtriple powerpc64-ibm-aix-xcoff -code-model=large \
+; RUN: -stop-after=machine-cp -print-before=simple-register-coalescing 2>&1 < \ 
+; RUN: %s | FileCheck --check-prefix=LARGE %s
----------------
Same comment.


================
Comment at: llvm/test/CodeGen/PowerPC/lower-globaladdr64-aix.ll:13
+; RUN: llc -mtriple powerpc64-ibm-aix-xcoff -stop-after=machine-cp \
+; RUN: -print-before=simple-register-coalescing 2>&1 < %s | FileCheck \
+; RUN: --check-prefix=SMALL %s
----------------
Same comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63547/new/

https://reviews.llvm.org/D63547